Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add data deposit fee to wasm functions #1818

Merged
merged 2 commits into from
Oct 11, 2024
Merged

add data deposit fee to wasm functions #1818

merged 2 commits into from
Oct 11, 2024

Conversation

OBorce
Copy link
Contributor

@OBorce OBorce commented Sep 20, 2024

  • normalise parameter types for nft and fungible token functions

@OBorce
add data deposit fee to wasm functions
dff6c7b 
- normalise parameter types for nft and fungible token functions
@OBorce OBorce force-pushed the feature/wasm-data-deposit-fee branch from 1800597 to dff6c7b Compare September 20, 2024 19:52
ImplOfAnImpl
ImplOfAnImpl approved these changes Oct 3, 2024
View reviewed changes
wasm-wrappers/src/lib.rs
Comment on lines +739 to +742
creator: Option<Vec<u8>>,
media_uri: Option<String>,
icon_uri: Option<String>,
additional_metadata_uri: Option<String>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why aren't these Option<&str> and Option<&[u8]>?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the wasm bindings generator doesn't know how to handle it.

@OBorce OBorce merged commit ff3b2c3 into master Oct 11, 2024
18 checks passed
@OBorce OBorce deleted the feature/wasm-data-deposit-fee branch October 11, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azarovh azarovh azarovh approved these changes

@ImplOfAnImpl ImplOfAnImpl ImplOfAnImpl approved these changes

@erubboli erubboli Awaiting requested review from erubboli erubboli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OBorce @ImplOfAnImpl @azarovh